Skip to content

Fix wrong document #43310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix wrong document #43310

wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Nov 28, 2024

The javadoc of StructuredLoggingJsonMembersCustomizer doesn't mention that, and I'm failed to reproduce it, I believe it cannot be loaded from spring.factories.

@quaff
Fix wrong document
fdf1673 
Currently, `org.springframework.boot.logging.structured.StructuredLoggingJsonMembersCustomizer` cannot be loaded from `spring.factories`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 28, 2024
@wilkinsona
Copy link
Member

Thanks, @quaff, but the documentation is correct. The customisers are loaded here:

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/structured/StructuredLogFormatterFactory.java

Lines 105 to 109 in 74d69d0

@SuppressWarnings({ "unchecked", "rawtypes" })
private List<StructuredLoggingJsonMembersCustomizer<?>> loadStructuredLoggingJsonMembersCustomizers() {
return (List) this.factoriesLoader.load(StructuredLoggingJsonMembersCustomizer.class,
ArgumentResolver.from(this.instantiator::getArg));
}

If that's not working for you, please open an issue with a minimal sample and we can investigate.

@wilkinsona wilkinsona closed this Nov 28, 2024
@wilkinsona wilkinsona added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 28, 2024
@quaff
Copy link
Contributor Author

quaff commented Nov 28, 2024

@wilkinsona #43312 created.

@quaff quaff deleted the patch-100 branch November 28, 2024 08:54
@quaff quaff mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: invalid An issue that we don't feel is valid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quaff @wilkinsona @spring-projects-issues